Add proxy for autocommit property on Connection #312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a proxy property for the
autocommit
property onsqlite3.Connection
objects.Use Case
I want
autocommit=False
as suggested by thesqlite3
docs (see docs). I also want to setPRAGMA journal_mode = WAL
. The issue is that I can't change thejournal_mode
when in a transaction, which is always the case whenautocommit=False
. So the solution is to set theautocommit
property after setting thejournal_mode
. This works fine insqlite3
, butaiosqlite
doesn't have the property.I can work around this by simply reaching into the
aiosqlite.Connection
object and accessing the_conn
attribute, but this is clearly not ideal.